[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91c4b5550ecf: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields (authored by dingfei fd...@feysh.com). Repository: rG LLVM Github

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D158145#4594569 , @cor3ntin wrote: > In D158145#4594549 , @danix800 > wrote: > >> I also

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 updated this revision to Diff 551078. danix800 added a comment. Remove debug code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added inline comments. Comment at: clang/unittests/AST/DeclTest.cpp:368 + ASTContext = AST->getASTContext(); + Ctx.getTranslationUnitDecl()->dump(); + balazske wrote: > This dump is not needed? Yeah it's for debug only, I'll remove it. Repository:

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

balazske added inline comments. Comment at: clang/unittests/AST/DeclTest.cpp:368 + ASTContext = AST->getASTContext(); + Ctx.getTranslationUnitDecl()->dump(); + This dump is not needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 updated this revision to Diff 551037. danix800 added a comment. 1. Update ReleaseNotes.rst 2. Fix typos pointed out by @cor3ntin (thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files:

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBase, +ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) { + Decl *From, *To; cor3ntin wrote: > danix800 wrote: > > cor3ntin

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

cor3ntin added a comment. In D158145#4594549 , @danix800 wrote: > I also investigated whether we could count those bits at compile time and > statically assert on them, > because a small typo or missed update could spend us a lot of time to dig for >

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added a comment. I also investigated whether we could count those bits at compile time and statically assert on them, because a small typo or missed update could spend us a lot of time to dig for the cause. My first step is trying to count number of bits for a single bitfield, this is

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836 +TEST_P(ASTImporterOptionSpecificTestBase, +ImportFunctionDeclBitShouldNotStampingOnCtorDeclBits) { + Decl *From, *To; cor3ntin wrote: >

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 added a comment. > Can you an an entry in `clang/docs/ReleaseNotes.rst` (mentioning the github > issue) No problem! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

cor3ntin added a comment. Thanks for working on this! Looks good to me except for a couple typos. Can you an an entry in `clang/docs/ReleaseNotes.rst` (mentioning the github issue) Comment at: clang/unittests/AST/ASTImporterTest.cpp:7836

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

cor3ntin added a comment. For context this seems to be the patch that did not increment the bit field https://reviews.llvm.org/D139837 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 updated this revision to Diff 551016. danix800 added a comment. Add alternative testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158145/new/ https://reviews.llvm.org/D158145 Files: clang/include/clang/AST/DeclBase.h

[PATCH] D158145: [clang] Update NumFunctionDeclBits for FunctionDeclBitfields

danix800 created this revision. danix800 added reviewers: aaron.ballman, cor3ntin, ychen, balazske. danix800 added a project: clang. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review of this revision. Herald added a subscriber: cfe-commits.