This revision was automatically updated to reflect the committed changes.
Closed by commit rG8c21544286a0: [clangd] Bump timeouts for LSPServerTests
(authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D158426?vs=552284=552354#toc
Repository:
rG LLVM Github Monorepo
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:42
[this] { return Value.has_value(); })) {
ADD_FAILURE() << "No result from
kadircet updated this revision to Diff 552284.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Just bump the timeouts
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158426/new/
https://reviews.llvm.org/D158426
Files:
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:27
std::unique_lock Lock(Mu);
- if (!clangd::wait(Lock, CV, timeoutSeconds(10),
[this] { return Value.has_value(); })) {
I think we're better
kadircet created this revision.
kadircet added reviewers: sammccall, nridge.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
We
