[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Bryan Chan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1561495cd128: [flang][driver] Mark -L as visible in Flang (authored by erjin, committed by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Hao Jin via Phabricator via cfe-commits
erjin added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Bryan Chan via Phabricator via cfe-commits
bryanpkc added inline comments. Comment at: clang/include/clang/Driver/Options.td:821 def L : JoinedOrSeparate<["-"], "L">, Flags<[RenderJoined]>, Group, +Visibility<[ClangOption, FlangOption]>, MetaVarName<"">, HelpText<"Add directory to library search path">;

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Hao Jin via Phabricator via cfe-commits
erjin added a comment. In D158763#4616664 , @awarzynski wrote: > LGTM, thank you! Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 553488. erjin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-25 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-24 Thread Hao Jin via Phabricator via cfe-commits
erjin updated this revision to Diff 553217. erjin added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158763/new/ https://reviews.llvm.org/D158763 Files: clang/include/clang/Driver/Options.td

[PATCH] D158763: [flang][driver] Mark -L as visible in Flang

2023-08-24 Thread Hao Jin via Phabricator via cfe-commits
erjin created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. erjin requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo