This revision was automatically updated to reflect the committed changes.
Closed by commit rG824b13659130: [clang][dataflow] Support range-for loops in
fixpoint algorithm. (authored by ymandel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
ymandel updated this revision to Diff 553958.
ymandel added a comment.
clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158848/new/
https://reviews.llvm.org/D158848
Files:
ymandel added inline comments.
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1631
+ const AnalysisOutputs &) {
+EXPECT_THAT(Results.keys(), UnorderedElementsAre("after_loop"));
+ });
mboehme wrote:
>
ymandel updated this revision to Diff 553929.
ymandel marked 2 inline comments as done.
ymandel added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158848/new/
https://reviews.llvm.org/D158848
Files:
mboehme accepted this revision.
mboehme added inline comments.
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:113
+ // Don't do anything special for CXXForRangeStmt, because the condition
(being
+ // implicitly generated) isn't visible from the
ymandel updated this revision to Diff 553505.
ymandel added a comment.
fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158848/new/
https://reviews.llvm.org/D158848
Files:
clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp
ymandel created this revision.
ymandel added reviewers: mboehme, xazax.hun.
Herald added a subscriber: martong.
Herald added a reviewer: NoQ.
Herald added a project: All.
ymandel requested review of this revision.
Herald added a project: clang.
Adds support for recognizing range-for loops in the
