[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4627313 , @PiotrZSL wrote: > From a mine perspective when it comes to clang-tidy: > > - I personally do not care about Objective-C specific matchers - I do not > plan to use them. > - I personally avoid using "Type"

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

PiotrZSL added a comment. From a mine perspective when it comes to clang-tidy: - I personally do not care about Objective-C specific matchers - I do not plan to use them. - I personally avoid using "Type" based matchers if I can (due to mess with elaborated/wrapped types), it's easier to

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4626272 , @sammccall wrote: > In D158872#4626095 , @aaron.ballman > wrote: > >> Out of curiosity, are you testing on Windows with MSVC? My understanding on >> build time

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. In D158872#4626095 , @aaron.ballman wrote: > Out of curiosity, are you testing on Windows with MSVC? My understanding on > build time performance impacts was that it's debug builds with MSVC that get > hit especially hard.

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added subscribers: carlosgalvezp, LegalizeAdulthood. aaron.ballman added a comment. In D158872#4626065 , @sammccall wrote: > I did some testing on my machine (host compiler clang-14), and I'm not sure > the specifics justify the level of

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. I did some testing on my machine (host compiler clang-14), and I'm not sure the specifics justify the level of caution here: ASTMatchers.h parses in 6.5s (with `clang-check`) If I comment out the code + internal ASTMatcher includes, then just the deps (mostly AST

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. Thanks for the history, I wasn't aware this was such a big deal for such a long time! In D158872#462 , @aaron.ballman wrote: >> A few ideas: >> >> - could we move these (and possibly other rarely-used matchers) to >>

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added a comment. In D158872#4625425 , @sammccall wrote: > In D158872#4624821 , @aaron.ballman > wrote: > >> In D158872#4623193 , @danix800 >> wrote: >>

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. In D158872#4624821 , @aaron.ballman wrote: > In D158872#4623193 , @danix800 > wrote: > >> In D158872#4622124 , >> @aaron.ballman wrote: >>

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added reviewers: r4nt, sammccall. aaron.ballman added a comment. In D158872#4623193 , @danix800 wrote: > In D158872#4622124 , @aaron.ballman > wrote: > >> Are these matchers going to be used

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4622124 , @aaron.ballman wrote: > Are these matchers going to be used in-tree (by clang-tidy, or something > else)? We typically do not add new AST matches until there's a need for them > because the AST matchers

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added a comment. Are these matchers going to be used in-tree (by clang-tidy, or something else)? We typically do not add new AST matches until there's a need for them because the AST matchers have a pretty big impact on build times of Clang itself. Comment at:

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 updated this revision to Diff 553779. danix800 added a comment. Update doc: fix improper naming in objc testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158872/new/ https://reviews.llvm.org/D158872 Files:

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 updated this revision to Diff 553697. danix800 added a comment. Update docs for `bitIntType` & `dependentBitIntType`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158872/new/ https://reviews.llvm.org/D158872 Files:

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 added a comment. In D158872#4618252 , @PiotrZSL wrote: > LGTM. > Nothing fancy, looks straight forward. > You may want to wait for an Aaron Ballman opinion. Thanks for the reviewing. Ping @aaron.ballman, could you please take a look at this

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM. Nothing fancy, looks straight forward. You may want to wait for an Aaron Ballman opinion. Comment at: clang/docs/LibASTMatchersReference.html:2454

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

danix800 created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. danix800 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a few type-related Matchers - bitIntType - constantMatrixType -