Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Eric Christopher via cfe-commits
echristo accepted this revision. echristo added a comment. Sure. -eric http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Davide Italiano via cfe-commits
davide added a comment. In http://reviews.llvm.org/D15899#319918, @dim wrote: > In http://reviews.llvm.org/D15899#319902, @davide wrote: > > > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 > > if backported) -- what about people running <= 10.2 ? Isn't this a

[PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
dim created this revision. dim added reviewers: davide, echristo, dexonsmith. dim added subscribers: emaste, ahatanak, cfe-commits, davide. Herald added subscribers: rengolin, aemerson. In rL256641, @davide turned off movt generation by default for FreeBSD. This was because our ld is very old,

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Davide Italiano via cfe-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Hmm, probably they can use the new frontend options so it's fine. LGTM. http://reviews.llvm.org/D15899 ___ cfe-commits mailing list

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Eric Christopher via cfe-commits
On Tue, Jan 5, 2016 at 12:29 PM Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Jan 05, 2016 at 08:12:34PM +, Dimitry Andric via cfe-commits > wrote: > > In rL256641, @davide turned off movt generation by default for FreeBSD. > > This was because our ld is

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Joerg Sonnenberger via cfe-commits
On Tue, Jan 05, 2016 at 08:12:34PM +, Dimitry Andric via cfe-commits wrote: > In rL256641, @davide turned off movt generation by default for FreeBSD. > This was because our ld is very old, and did not support the relocations > for it. However, Ian Lepore added the support very recently, so we

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Ed Maste via cfe-commits
>> Is there a precendent for the option name? It should be -m* and not -f*, >> since it is not target independent. > > Yes, agreed, thanks for the catch Joerg. Presumably -ffixed_r9 should become -mfixed_r9 as well? ___ cfe-commits mailing list

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
dim updated this revision to Diff 44059. dim added a comment. Rename `-fno-movt` to `-mno-movt`. http://reviews.llvm.org/D15899 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/arm-no-movt.c Index: test/Driver/arm-no-movt.c

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Ed Maste via cfe-commits
emaste accepted this revision. emaste added a reviewer: emaste. emaste added a comment. This LGTM http://reviews.llvm.org/D15899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Dimitry Andric via cfe-commits
dim added a comment. In http://reviews.llvm.org/D15899#319902, @davide wrote: > I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 > if backported) -- what about people running <= 10.2 ? Isn't this a problem > for them? People running ports-provided or hand-built

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Davide Italiano via cfe-commits
davide added a comment. I'm not opposed to this but ... this will likely it only 11 (and maybe 10.3 if backported) -- what about people running <= 10.2 ? Isn't this a problem for them? http://reviews.llvm.org/D15899 ___ cfe-commits mailing list

Re: [PATCH] D15899: Add -fno-movt frontend option, to disable movt/movw on ARM

2016-01-05 Thread Eric Christopher via cfe-commits
On Tue, Jan 5, 2016 at 12:43 PM Ed Maste wrote: > >> Is there a precendent for the option name? It should be -m* and not -f*, > >> since it is not target independent. > > > > Yes, agreed, thanks for the catch Joerg. > > Presumably -ffixed_r9 should become -mfixed_r9 as well?