NoQ updated this revision to Diff 44628.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Good point! Removed the friend-class directive here, and also in
`NonStaticGlobalSpaceRegion`, which is also abstract.
Agreed and renamed text regions to code regions.
dcoughlin added a comment.
Looks good to me. Thanks for making this more consistent!
Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:102
@@ -103,1 +101,3 @@
+BEGIN_TYPED_REGIONS,
+FunctionTextRegionKind = BEGIN_TYPED_REGIONS,
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
Based on discussion in D15448.
- For every sub-class `C`, its kind in the relevant enumeration is `CKind` (or
`C##Kind` in preprocessor-ish terms), eg:
`MemRegionKind` ->
zaks.anna added a comment.
> MemSpaceRegion is now an abstract base
What prevents it from being instantiated?
http://reviews.llvm.org/D16062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
