andreybokhanko added a comment.
@rafael, thank you!
In http://reviews.llvm.org/D16138#325739, @rafael wrote:
> LGTM, but could you change the default in a followup commit? TargetInfo
> should really be setting it to "" since it is far more common than "_".
Sure, will do.
Yours,
Andrey
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257756: Correct setting of UserLabelPrefix for MCU target.
(authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D16138?vs=44726=44849#toc
Repository:
rL LLVM
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, mkuper.
andreybokhanko added a subscriber: cfe-commits.
Correct setting of UserLabelPrefix for MCU target
http://reviews.llvm.org/D16138
Files:
lib/Basic/Targets.cpp
test/Preprocessor/elfiamcu-predefines.c
Index:
andreybokhanko updated this revision to Diff 44726.
andreybokhanko added a comment.
Patch updated to be in line with llvm trunk. Sorry for the noise.
http://reviews.llvm.org/D16138
Files:
lib/Basic/Targets.cpp
test/Preprocessor/elfiamcu-predefines.c
Index: lib/Basic/Targets.cpp
rafael added a subscriber: rafael.
rafael accepted this revision.
rafael added a reviewer: rafael.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM, but could you change the default in a followup commit? TargetInfo should
really be setting it to "" since it is far
