This revision was automatically updated to reflect the committed changes.
Closed by commit rL288896: Implement the -Wstrict-prototypes warning (authored
by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D16533?vs=80285&id=80560#toc
Repository:
rL LLVM
https://reviews.llvm.org/
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
arphaman updated this revision to Diff 80285.
arphaman marked 2 inline comments as done.
arphaman added a comment.
The updated patch addresses Bruno's comments.
Repository:
rL LLVM
https://reviews.llvm.org/D16533
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaDecl.cpp
l
bruno added a comment.
Hi Alex, thanks for following up with this!
Comment at: lib/Sema/SemaDecl.cpp:11819
+ // Warn if K&R function is defined without previous declaration
+ // declaration. This warning is issued only if the difinition itself
+ // does not
arphaman added a comment.
Ping
Repository:
rL LLVM
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added reviewers: rsmith, bruno.
arphaman set the repository for this revision to rL LLVM.
arphaman updated this revision to Diff 77351.
arphaman added a comment.
I rebased the patch, adjusted the test and added a test case for Objective-C
blocks.
Repository:
rL LLVM
https://reviews.
arphaman added a comment.
Hi Paul,
Are you planning to work on this patch? If not, can I take a shot at it?
Cheers,
Alex
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
bruno added a subscriber: bruno.
bruno added a comment.
Hi Paul,
I'm interested in this patch. Do you have any plans to wrap it up?
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
thakis added a subscriber: thakis.
thakis added a comment.
(This is http://llvm.org/PR20796, which has some discussion and test cases. If
you haven't, maybe you want to look at the test cases there. It's possible
they're a subset of your test though.)
http://reviews.llvm.org/D16533
Thanks for the fast review.
> On Mon, Jan 25, 2016 at 03:18:31PM +, Paul Titei via cfe-commits wrote:
> > +// function definition with 0 params(for both cases), valid according
> > +to 6.7.5.3/14 void foo1() {}
> I still want to get a warning for this. At best it is inconsistent.
I agree this
Thanks for working on this!
On Mon, Jan 25, 2016 at 03:18:31PM +, Paul Titei via cfe-commits wrote:
> +// function definition with 0 params(for both cases), valid according to
> 6.7.5.3/14
> +void foo1() {}
I still want to get a warning for this. At best it is inconsistent.
> +// Function d
ptitei created this revision.
ptitei added a reviewer: cfe-commits.
Implementation for C only warning -Wstrict-prototypes. Function declarations
which have no parameters specified are diagnosed and also K&R function
definitions with more than 0 parameters which are not preceded by previous
prot
12 matches
Mail list logo
