alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good! I'll commit the patch for you.
http://reviews.llvm.org/D16587
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL259197: Fixed function params comparison. Updated docs and
tests. (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D16587?vs=46360=46382#toc
Repository:
rL LLVM
congliu updated this revision to Diff 46359.
congliu added a comment.
- Fixed bugs introduced by getCanonicalDecl. Has errs log.
- Cleared up logs.
- Added mathcers for static method and overloaded operator.
- Change key type of map from string to pointer to imporve performance.
- Change
congliu updated this revision to Diff 46360.
congliu added a comment.
- Fixed a nit in test file.
http://reviews.llvm.org/D16587
Files:
clang-tidy/misc/VirtualNearMissCheck.cpp
clang-tidy/misc/VirtualNearMissCheck.h
docs/clang-tidy/checks/misc-virtual-near-miss.rst
congliu created this revision.
congliu added a reviewer: alexfh.
congliu added a subscriber: cfe-commits.
"checkParamTypes" may fail if the the type of some parameter is not canonical.
Fixed it by comparing canonical types. And added "getCanonicalType()" and
"getCanonicalDecl()" on more places
