Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good now. Thank you! http://reviews.llvm.org/D16922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu closed this revision. congliu added a comment. Closed by commit rL260532: Merge branch 'arcpatch-D16922' (authored by congliu ) http://reviews.llvm.org/D16922 ___

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu added a comment. The strategy has changed. Now this check does not ignore template in instantiation, instead, it generate a single warning for some instantiation and ignore others, so that fix is able to apply. We do this to walk around the function copied from ASTMatchFinder, since

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added a comment. > The strategy has changed. Now this check does not ignore template in > instantiation, instead, it generate a > single warning for some instantiation and ignore others, so that fix is able > to apply. I'm not sure this is the right thing to do, since there might be

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47448. congliu marked 2 inline comments as done. congliu added a comment. - Generate a single warning for multiple template instantiations. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47461. congliu marked 3 inline comments as done. congliu added a comment. - Allowed warnings but disallowed fix for template instantiations. - Updated tests. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47307. congliu added a comment. - Disallowed matches for method in template instantiations. Updated test. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index:

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:183 @@ +182,3 @@ +/// +/// This function is copied from the one defined in ASTMatchFinder.cpp to solve +/// the problem that QualType::getAsCXXRecordDecl does not work for template

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added inline comments. Comment at: test/clang-tidy/misc-virtual-near-miss.cpp:1 @@ -1,2 +1,2 @@ // RUN: %check_clang_tidy %s misc-virtual-near-miss %t The check shouldn't make any changes to template classes based on any single instantiation. An easy

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu updated this revision to Diff 47024. congliu added a comment. - Added test cases of macro and template. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index: test/clang-tidy/misc-virtual-near-miss.cpp

[PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

congliu created this revision. congliu added a reviewer: alexfh. congliu added a subscriber: cfe-commits. Addes FixItHint and updated test. http://reviews.llvm.org/D16922 Files: clang-tidy/misc/VirtualNearMissCheck.cpp test/clang-tidy/misc-virtual-near-miss.cpp Index:

Re: [PATCH] D16922: [clang-tidy] Added check-fixes for misc-virtual-near-miss.

alexfh added inline comments. Comment at: clang-tidy/misc/VirtualNearMissCheck.cpp:252 @@ -251,1 +251,3 @@ // A "virtual near miss" is found. +auto Range = CharSourceRange::getTokenRange(SourceRange( +DerivedMD->getLocation(),