EricWF closed this revision.
EricWF added a comment.
Committed as r273034.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a reviewer: EricWF.
EricWF added a comment.
This revision is now accepted and ready to land.
Accepting before committing. Speak now or forever hold your peace. (Or just
speak post commit)
http://reviews.llvm.org/D16948
rmaprath added a comment.
In http://reviews.llvm.org/D16948#457266, @EricWF wrote:
> Add `LIBCXX_ENABLE_FILESYSTEM` CMake option to turn off only the filesystem
> parts of `libc++experimental.a`.
Thanks!
http://reviews.llvm.org/D16948
___
rmaprath added a comment.
> > Fine by me.
>
> >
>
> > I didn't have much time to go through the patch, is there a way to disable
> > this module from building? It won't compile for our targets until we put in
> > some sort of a porting layer (which I need to start thinking of). Would be
EricWF added a comment.
In http://reviews.llvm.org/D16948#456966, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#456929, @EricWF wrote:
>
> > Unless there are any objections I plan to commit this change on Friday.
> >
> > That will give it about a month of in-tree time before the 3.9
rmaprath added a comment.
In http://reviews.llvm.org/D16948#456929, @EricWF wrote:
> Unless there are any objections I plan to commit this change on Friday.
>
> That will give it about a month of in-tree time before the 3.9 release branch.
Fine by me.
I didn't have much time to go through the
EricWF added a comment.
Unless there are any objections I plan to commit this change on Friday.
That will give it about a month of in-tree time before the 3.9 release branch.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
EricWF added a comment.
@mclow.lists Just a reminder that 3.9 branches for release on July 19th.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF marked an inline comment as done.
Comment at: src/experimental/operations.cpp:128-129
@@ +127,4 @@
+bool stat_equivalent(struct ::stat& st1, struct ::stat& st2) {
+return (st1.st_dev == st2.st_dev && st1.st_ino == st2.st_ino);
+}
+
majnemer wrote:
> It
ahatanak added a subscriber: ahatanak.
Comment at: test/std/utilities/meta/meta.rel/is_nothrow_callable.pass.cpp:57
@@ -56,3 +56,3 @@
struct Dummy { void foo() noexcept {} static void bar() noexcept {} };
-#if !defined(__cpp_noexcept_function_type)
+#if
majnemer added inline comments.
Comment at: src/experimental/operations.cpp:128-129
@@ +127,4 @@
+bool stat_equivalent(struct ::stat& st1, struct ::stat& st2) {
+return (st1.st_dev == st2.st_dev && st1.st_ino == st2.st_ino);
+}
+
It is possible for `st_ino`
majnemer added inline comments.
Comment at: src/experimental/operations.cpp:529
@@ +528,3 @@
+
+if (::utimensat(AT_FDCWD, p.c_str(), tbuf, 0) == -1) {
+m_ec = detail::capture_errno();
SUSv4 says:
> The utime() function is marked obsolescent.
rmaprath added a comment.
In http://reviews.llvm.org/D16948#444013, @EricWF wrote:
> The git branch I develop on is public:
> https://github.com/efcs/libcxx/tree/filesystem-ts
>
> You can download or clone from there (and it will always be up to date!).
All tests pass! :-)
I'll try to find
EricWF added a comment.
The git branch I develop on is public:
https://github.com/efcs/libcxx/tree/filesystem-ts
You can download or clone from there (and it will always be up to date!).
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
EricWF added a comment.
In http://reviews.llvm.org/D16948#444009, @rmaprath wrote:
> Would you / community be open to the idea of hiding the os syscalls behind an
> API? (like we are doing for pthreads)?
Yes I would be very open to that. Then I could also have test shims in order to
test
rmaprath added a comment.
In http://reviews.llvm.org/D16948#444010, @EricWF wrote:
> Ah I figured it out! The test suite has symlinks within it. Git handles them
> properly but they obviously don't survive the round trip to phabricator and
> back. So all of the tests that depend on them fail
EricWF added a comment.
Ah I figured it out! The test suite has symlinks within it. Git handles them
properly but they obviously don't survive the round trip to phabricator and
back. So all of the tests that depend on them fail (with is evidently a lot).
http://reviews.llvm.org/D16948
rmaprath added a comment.
Would you / community be open to the idea of hiding the os syscalls behind an
API? (like we are doing for pthreads)?
I think this is the only way we could get at least some of this functionality
working on bare-metal ARM (it should work on arm-linux without much
rmaprath added a comment.
In http://reviews.llvm.org/D16948#444006, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
>
> > I installed a Fedora 23 system and ran the test suite and I didn't see any
> > of the same failures. It must be something other than the distro.
EricWF added a comment.
In http://reviews.llvm.org/D16948#444006, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
>
> > I installed a Fedora 23 system and ran the test suite and I didn't see any
> > of the same failures. It must be something other than the distro.
>
rmaprath added a comment.
In http://reviews.llvm.org/D16948#443999, @EricWF wrote:
> I installed a Fedora 23 system and ran the test suite and I didn't see any of
> the same failures. It must be something other than the distro.
> Are you using an odd filesystem? Or maybe it could be your
EricWF added a comment.
In http://reviews.llvm.org/D16948#443945, @rmaprath wrote:
> In http://reviews.llvm.org/D16948#443942, @EricWF wrote:
>
> > In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
> >
> > > I'm seeing a few failures on my Fedora 20 system. Will go through these
> > >
EricWF marked 6 inline comments as done.
EricWF added a comment.
@majnemer Thanks for looking at this!
Comment at: include/experimental/filesystem:610
@@ +609,3 @@
+static void __append_range(string& __dest, _Iter __b, _Iter __e) {
+// TODO(EricWF) We get better
majnemer added a subscriber: majnemer.
Comment at: include/experimental/filesystem:610
@@ +609,3 @@
+static void __append_range(string& __dest, _Iter __b, _Iter __e) {
+// TODO(EricWF) We get better allocation behavior here if we don't
+// provide the same
EricWF added a comment.
Thanks. I fixed the missing include causing most of the failures. Please update
me when you can with new results.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rmaprath added a comment.
In http://reviews.llvm.org/D16948#443942, @EricWF wrote:
> In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
>
> > I'm seeing a few failures on my Fedora 20 system. Will go through these
> > tomorrow.
>
>
> If you want to just send me the raw ouput I'll go
EricWF added a comment.
In http://reviews.llvm.org/D16948#443941, @rmaprath wrote:
> I'm seeing a few failures on my Fedora 20 system. Will go through these
> tomorrow.
If you want to just send me the raw ouput I'll go over them tonight.
http://reviews.llvm.org/D16948
rmaprath added a comment.
I'm seeing a few failures on my Fedora 20 system. Will go through these
tomorrow.
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
In http://reviews.llvm.org/D16948#438880, @rmaprath wrote:
> Looks like I've completely missed this patch somehow. Will try to find some
> time (or someone) to have a look at it from an embedded-systems / ARM point
> of view asap.
>
> Great work!!!
Thanks! Even just
rmaprath added a subscriber: rmaprath.
rmaprath added a comment.
Looks like I've completely missed this patch somehow. Will try to find some
time (or someone) to have a look at it from an embedded-systems / ARM point of
view asap.
Great work!!!
http://reviews.llvm.org/D16948
EricWF added a comment.
For reference here's the current test coverage:
http://efcs.ca/filesystem-coverage/
http://reviews.llvm.org/D16948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
31 matches
Mail list logo
