carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Committed revision 262741.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
carlo.bertolli updated this revision to Diff 48691.
carlo.bertolli added a comment.
Address latest comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
carlo.bertolli marked 5 inline comments as done.
carlo.bertolli added a comment.
Updating patch following comments.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:2126
@@ +2125,3 @@
+ OpenMPSchedType ScheduleNum = getRuntimeSchedule(ScheduleKind, Chunk !=
nullptr,
+Ordered);
+ auto *UpdatedLocation =
carlo.bertolli updated this revision to Diff 48526.
carlo.bertolli added a comment.
Update to trunk and implement suggestions from latest review: do not make
public methods used in static function calling kmpc_for_static_init, but call
those functions in the caller that can access them.
carlo.bertolli updated this revision to Diff 48379.
carlo.bertolli marked 4 inline comments as done.
carlo.bertolli added a comment.
Partially address comments to replace schedule type with schedule num in
interface of static function generating call to kmpc_for_static_init. Still
waiting for
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:187-208
@@ -185,30 +186,24 @@
+
+public:
/// \brief Values for bit flags used in the ident_t to describe the fields.
/// All enumeric elements are named and described in accordance with the code
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1876-1878
@@ +1875,5 @@
+ SourceLocation Loc,
+ OpenMPScheduleClauseKind ForSchedKind,
+
carlo.bertolli updated this revision to Diff 48273.
carlo.bertolli added a comment.
Update to new version of http://reviews.llvm.org/D17148, integrating changes
from the trunk.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
carlo.bertolli updated this revision to Diff 48200.
carlo.bertolli added a comment.
Updated diff reflecting comments.
Note that having the emission of the runtime kmpc_for_static_init function in a
static function (instead of a method of CGOpenMPRuntime) required moving to
public some fields in
carlo.bertolli marked 4 inline comments as done.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:2914
@@ -2713,4 +2913,3 @@
if (NT || TL) {
-NumTeamsVal = (NT) ? CGF.EmitScalarExpr(NT->getNumTeams(),
-/* IgnoreResultAssign = */ true) :
+NumTeamsVal = (NT) ?
ABataev added a comment.
Carlo, thanks for the patch! Please update the code to trunk HEAD
Comment at: lib/CodeGen/CGOpenMPRuntime.h:677
@@ -676,1 +676,3 @@
+ virtual bool isStaticNonchunked(OpenMPDistScheduleClauseKind ScheduleKind,
+ bool
carlo.bertolli updated this revision to Diff 48100.
carlo.bertolli added a comment.
Address comments and rebase over new version of http://reviews.llvm.org/D17148.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Comment at:
carlo.bertolli added a comment.
I have addressed some of the comments and restructured the code as requested.
Let me know about further comments.
Thanks for making this a better patch!
Repository:
rL LLVM
http://reviews.llvm.org/D17170
___
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction ,
+SourceLocation Loc,
carlo.bertolli wrote:
> I added this
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:759
@@ +758,3 @@
+ ///
+ void emitForStaticInitWithKMPSchedule(CodeGenFunction ,
+SourceLocation Loc,
I added this because
carlo.bertolli updated this revision to Diff 47921.
carlo.bertolli added a comment.
Reflect changes in http://reviews.llvm.org/D17148 and show full context.
Repository:
rL LLVM
http://reviews.llvm.org/D17170
Files:
include/clang/AST/StmtOpenMP.h
lib/CodeGen/CGOpenMPRuntime.cpp
ABataev added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.h:669-692
@@ -668,1 +668,26 @@
+ /// \brief Schedule types for 'omp for' loops (these enumerators are taken
from
+ /// the enum sched_type in kmp.h).
+ enum OpenMPSchedType {
+ /// \brief Lower
20 matches
Mail list logo
