Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

2016-03-07 Thread don hinton via cfe-commits
hintonda added a comment. Great, thanks David. http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

2016-03-07 Thread David Majnemer via cfe-commits
majnemer closed this revision. majnemer added a comment. I committed this a few days ago in http://reviews.llvm.org/rL262466. Closing this differential. http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

2016-02-22 Thread don hinton via cfe-commits
hintonda added a comment. Thanks David. Btw, could you commit it for me? I don't have commit access. http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

2016-02-22 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D17248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17248: [Sema] PR26444 fix crash when alignment value is >= 2**16

2016-02-22 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 48742. hintonda added a comment. Added comment Added comment to test file. http://reviews.llvm.org/D17248 Files: lib/CodeGen/CGValue.h test/Sema/attr-aligned.c Index: test/Sema/attr-aligned.c

[PATCH] D17248: [Sema] PR26444 fix crash when alignment value is <= 2**16

2016-02-14 Thread don hinton via cfe-commits
hintonda created this revision. hintonda added a reviewer: majnemer. hintonda added a subscriber: cfe-commits. Sema allows max values up to 2**28, use unsigned instead of unsiged short to hold values that large. http://reviews.llvm.org/D17248 Files: lib/CodeGen/CGValue.h