aaron.ballman added a comment.
In http://reviews.llvm.org/D17709#374561, @rnk wrote:
> Unless there is a compelling example of Microsoft or a popular third-party
> header relying on this behavior, I don't think we should implement it.
Agreed.
Comment at:
olga.a.chupina added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:4811
@@ -4810,2 +4810,3 @@
case tok::kw___unaligned:
- if (AttrReqs & AR_DeclspecAttributesParsed) {
+ // Allow __unaligned in function definition after a parameter list
+ if ((AttrReqs
rnk added a comment.
Unless there is a compelling example of Microsoft or a popular third-party
header relying on this behavior, I don't think we should implement it.
Comment at: lib/Parse/ParseDecl.cpp:4813
@@ -4812,1 +4812,3 @@
+ if ((AttrReqs &
aaron.ballman added a subscriber: aaron.ballman.
Comment at: lib/Parse/ParseDecl.cpp:4811
@@ -4810,2 +4810,3 @@
case tok::kw___unaligned:
- if (AttrReqs & AR_DeclspecAttributesParsed) {
+ // Allow __unaligned in function definition after a parameter list
+ if
olga.a.chupina added a comment.
Reid, cloud you please review the patch.
http://reviews.llvm.org/D17709
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
olga.a.chupina created this revision.
olga.a.chupina added a reviewer: rnk.
olga.a.chupina added a subscriber: cfe-commits.
This patch supports using '__unaligned' attribute in function declaration:
struct UnalignedS {
void foo(double) __unaligned { ; }
};
void bar(void
