This revision was automatically updated to reflect the committed changes.
Closed by commit rL262789: [Modules] Don't swallow errors when parsing optional
attributes. (authored by davide).
Changed prior to commit:
http://reviews.llvm.org/D17787?vs=49575=49888#toc
Repository:
rL LLVM
silvas added a comment.
This makes sense. LGTM.
http://reviews.llvm.org/D17787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davide added a reviewer: rsmith.
davide updated this revision to Diff 49575.
davide added a comment.
Added a test. Yes, with the patch we stop immediately if we fail to parse
attributes, while the old code kept emitting diagnostics. I like the new
behaviour better, but I'll defer the decision
silvas added a comment.
makes sense. can you include a testcase? I assume we are forgetting some sort
of diagnostic without this patch.
Also, if learning about Clang's modules, I would start with `addHeaderInclude`
in lib/Frontend/FrontendActions.cpp. The module map stuff ultimately boils down
davide created this revision.
davide added reviewers: silvas, doug.gregor.
davide added a subscriber: cfe-commits.
I found this by visual inspection while trying to get up-to-speed on modules,
so I'm still uncertain how to test it. If the current one is really the actual
behaviour, then parse
