Re: [PATCH] D17794: [modules] addHeaderInclude() can't fail.

2016-03-01 Thread Davide Italiano via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL262463: [modules] addHeaderInclude() can't fail. (authored by davide). Changed prior to commit: http://reviews.llvm.org/D17794?vs=49578=49581#toc Repository: rL LLVM http://reviews.llvm.org/D17794

Re: [PATCH] D17794: [modules] addHeaderInclude() can't fail.

2016-03-01 Thread Sean Silva via cfe-commits
silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. Nice cleanup. LGTM. http://reviews.llvm.org/D17794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17794: [modules] addHeaderInclude() can't fail.

2016-03-01 Thread Davide Italiano via cfe-commits
davide added a comment. As an added bonus, this simplifies the code a little bit. http://reviews.llvm.org/D17794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D17794: [modules] addHeaderInclude() can't fail.

2016-03-01 Thread Davide Italiano via cfe-commits
davide created this revision. davide added reviewers: silvas, rsmith, christof. davide added a subscriber: cfe-commits. I noticed that addHeaderInclude() returns bool although it can never fail. I find this a little bit weird from a semantic point of view. My best guess is that the 'bool'