rsmith added a comment.
I would prefer that we solve this problem generically for all files that Clang
tries to open, not just for module map files. (Note, for instance, that PR20468
concerns files referenced by module map files, such as their nominated headers,
not the module map files
davide added a comment.
Hmm, I think you're right. It's not actually that silent (it fails with a fatal
error when trying to load/read).
That said, I think it might still be valuable to emit a diagnostic -- Richard
what do you think?
I noticed you reported a very similar problem here:
silvas added a comment.
Isn't there a `read` call or something that fails down the road? How can it be
silent?
http://reviews.llvm.org/D18011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
davide updated this revision to Diff 50181.
davide added a comment.
Typo.
http://reviews.llvm.org/D18011
Files:
include/clang/Basic/DiagnosticFrontendKinds.td
lib/Frontend/FrontendActions.cpp
test/Modules/Inputs/insufficient-privileges.modulemap
Index: lib/Frontend/FrontendActions.cpp
davide created this revision.
davide added reviewers: rsmith, silvas, doug.gregor.
davide added a subscriber: cfe-commits.
I stumbled upon this yesterday. Without this patch in palce, the module map
load is silently ignored, and this might cause subtle breakages.
http://reviews.llvm.org/D18011
