joker.eph closed this revision.
joker.eph added a comment.
r263394
http://reviews.llvm.org/D18127
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Interesting question going forwards: We usually try to make test cases
+/-Asserts agnostic (not using named values), now that we have a flag for
it, should we not bother with that & just add the command line argument to
enable names when names make testing easier? Or do we think that'll make
tests
chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.
Looks good with the two test nits below fixed.
Comment at: test/CodeGen/mips-zero-sized-struct.c:8-10
@@ -7,5 +7,5 @@
-// O32: define void @fn28(%struct.T2* noalias sr
joker.eph updated this revision to Diff 50546.
joker.eph added a comment.
s/clang -cc1/%clang_cc1/
http://reviews.llvm.org/D18127
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/CGBuilder.h
lib/CodeGen/CGCall.cpp
lib/CodeGen/CGExpr.cpp
joker.eph updated this revision to Diff 50541.
joker.eph added a comment.
Use cc1 in the few tests that were relying on value names. Also add
test/CodeGenCXX/discard-name-values.cpp to test the new cc1 flag.
http://reviews.llvm.org/D18127
Files:
include/clang/Driver/CC1Options.td
include/c
chandlerc added a comment.
Change these tests to use %clang_cc1 rather than add all the messy regex to
handle arguments losing names?
Comment at: lib/Driver/Tools.cpp:3715
@@ -3714,1 +3714,3 @@
CmdArgs.push_back("-disable-llvm-verifier");
+ // Disable LLVM value names in -a
joker.eph created this revision.
joker.eph added reviewers: echristo, chandlerc.
joker.eph added a subscriber: cfe-commits.
This flag is enabled by default in the driver when NDEBUG is set. It
is forwarded on the LLVMContext to discard all value names (but
GlobalValue) for performance purpose.
Th
