tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Hahnfeld added a comment.
@tra any more comments on this?
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a subscriber: Hahnfeld.
Hahnfeld added a comment.
Is there any progress on this one?
http://reviews.llvm.org/D18170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao added a comment.
Hi Art,
Thanks for the the review!
Comment at: include/clang/Driver/Action.h:79
@@ +78,3 @@
+OFFLOAD_None = 0x00,
+OFFLOAD_CUDA = 0x01,
+ };
tra wrote:
> Nit: All-caps CUDA looks weird here. _Cuda may be better choice.
> If
sfantao updated this revision to Diff 52878.
sfantao marked 6 inline comments as done.
sfantao added a comment.
Address Art and Eric comments.
http://reviews.llvm.org/D18170
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
tra added inline comments.
Comment at: include/clang/Driver/Action.h:79
@@ +78,3 @@
+OFFLOAD_None = 0x00,
+OFFLOAD_CUDA = 0x01,
+ };
Nit: All-caps CUDA looks weird here. _Cuda may be better choice.
If you can shorten the prefix that would be nice, too.
sfantao created this revision.
sfantao added reviewers: ABataev, jlebar, tra, echristo, hfinkel.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob, cfe-commits.
This patch introduces the concept of offloading tool chain and offloading kind.
Each tool chain may have associated an
