Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Davide Italiano via cfe-commits
davide added a subscriber: davide. davide added a comment. LGTM. Repository: rL LLVM http://reviews.llvm.org/D19029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Davide Italiano via cfe-commits
LGTM. On Tue, Apr 12, 2016 at 2:17 PM, Ed Maste wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for > -static (authored by emaste). > > Changed prior to commit: >

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Ed Maste via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL266123: Always use --eh-frame-hdr on FreeBSD, even for -static (authored by emaste). Changed prior to commit: http://reviews.llvm.org/D19029?vs=53452=53460#toc Repository: rL LLVM

Re: [PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Rafael Ávila de Espíndola via cfe-commits
rafael added a subscriber: rafael. rafael accepted this revision. rafael added a reviewer: rafael. rafael added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D19029 ___ cfe-commits mailing list

[PATCH] D19029: Always use --eh-frame-hdr on FreeBSD, even for -static

2016-04-12 Thread Ed Maste via cfe-commits
emaste created this revision. emaste added reviewers: dim, andrew, davide. emaste added a subscriber: cfe-commits. Herald added subscribers: emaste, aemerson. FreeBSD uses LLVM's libunwind on FreeBSD/arm64 today (and we expect to use it more widely in the future) and it requires the EH frame