Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-06-10 Thread Clement Courbet via cfe-commits
courbet closed this revision. courbet added a comment. This was submitted as r272386. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-06-03 Thread Piotr Padlewski via cfe-commits
Just ask Chris for the access :) 03.06.2016 11:26 AM "Clement Courbet via cfe-commits" < cfe-commits@lists.llvm.org> napisał(a): > courbet added a comment. > > @sbenza @aaron.ballman I don't have write access. Can one of you submit > this on my behalf ? Thanks ! > > >

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-06-03 Thread Clement Courbet via cfe-commits
courbet added a comment. That could work :) I'm not sure my commit history is considered a "track record of submitting high quality patches" but I'll give it a try. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-06-03 Thread Clement Courbet via cfe-commits
courbet added a comment. @sbenza @aaron.ballman I don't have write access. Can one of you submit this on my behalf ? Thanks ! http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-06-03 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 59502. courbet added a comment. Rebase on origin/master http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-23 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + typedef llvm::iterator_range + overridden_method_range; Sure. Sorry about that. The

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-20 Thread Clement Courbet via cfe-commits
courbet marked 10 inline comments as done. courbet added a comment. http://reviews.llvm.org/D19324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-19 Thread Clement Courbet via cfe-commits
courbet added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3776 @@ +3775,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Builder); Thanks for the

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-19 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 57757. courbet added a comment. clang-format diff http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-19 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 57756. courbet added a comment. Rebase on HEAD. http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-18 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder OverriddenBuilder(*Builder); courbet

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-17 Thread Clement Courbet via cfe-commits
courbet added a comment. Thanks. Could please you submit this for me ? Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (const auto *Overridden : Node.overridden_methods()) { +BoundNodesTreeBuilder

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-17 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 57473. courbet added a comment. cometics http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h include/clang/ASTMatchers/ASTMatchers.h lib/AST/ASTContext.cpp

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-17 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, with one minor nit. Thank you for working on this! Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-17 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 57462. courbet added a comment. Use iterator_range instead of ArrayRef for overridden_methods http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h include/clang/AST/DeclCXX.h

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-03 Thread Clement Courbet via cfe-commits
courbet added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const;

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-03 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const;

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-03 Thread Clement Courbet via cfe-commits
courbet added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const;

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-05-03 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/AST/ASTContext.h:824 @@ -823,1 +823,3 @@ unsigned overridden_methods_size(const CXXMethodDecl *Method) const; + const ArrayRef overridden_methods( + const CXXMethodDecl *Method) const; This

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-26 Thread Samuel Benzaquen via cfe-commits
sbenza added inline comments. Comment at: include/clang/AST/DeclCXX.h:1830 @@ -1829,2 +1829,3 @@ unsigned size_overridden_methods() const; + const ArrayRef overridden_methods() const; Return type should have have toplevel `const`. Comment

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-25 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 54830. courbet marked an inline comment as done. courbet added a comment. overridden_methods return ArrayRef instead of TinyPtrVector* http://reviews.llvm.org/D19324 Files: docs/LibASTMatchersReference.html include/clang/AST/ASTContext.h

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@ +3723,3 @@ + bool Matched = false; + for (auto It = Node.begin_overridden_methods(); + It != Node.end_overridden_methods(); ++It) { courbet wrote: >

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Please run clang\docs\tools\dump_ast_matchers.py to regenerate the documentation as well. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3724 @@

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-21 Thread Clement Courbet via cfe-commits
courbet updated this revision to Diff 54462. courbet marked an inline comment as done. courbet added a comment. Fix typo in doc. http://reviews.llvm.org/D19324 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersTest.cpp

Re: [PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-20 Thread Mandeep Singh Grang via cfe-commits
mgrang added a subscriber: mgrang. Comment at: include/clang/ASTMatchers/ASTMatchers.h:3719 @@ +3718,3 @@ +/// matches twice, once with "b" binding "A1::f" and "d" binding "C::f", and +/// once with "b" binding "A2::f" and "d" binding "C::f", and +AST_MATCHER_P(CXXMethodDecl,

[PATCH] D19324: [ASTMatchers] new forEachOverriden matcher

2016-04-20 Thread Clement Courbet via cfe-commits
courbet created this revision. courbet added a subscriber: cfe-commits. Herald added a subscriber: klimek. Matches methods overridden by the given method. http://reviews.llvm.org/D19324 Files: include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp