Re: [PATCH] D19620: [libc++] Add braces, move braces, and rename variables to avoid shadowing.

2016-04-27 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r267844. http://reviews.llvm.org/D19620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19620: [libc++] Add braces, move braces, and rename variables to avoid shadowing.

2016-04-27 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I hope the actual warning says 'meow' in all cases. http://reviews.llvm.org/D19620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19620: [libc++] Add braces, move braces, and rename variables to avoid shadowing.

2016-04-27 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: mclow.lists, EricWF. STL_MSFT added a subscriber: cfe-commits. [libc++] Add braces, move braces, and rename variables to avoid shadowing. Fixes MSVC "warning C4456: declaration of 'meow' hides previous local declaration".