Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

Sounds great. Thanks! -eric On Wed, May 4, 2016 at 4:36 AM Andrey Turetskiy wrote: > aturetsk added a comment. > > Hi, > Thanks for the review. > > Committed: > > 1. Add a test for driver options from m_x86_Features_Group ( > http://reviews.llvm.org/rL268487) > 2.

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk added a comment. Hi, Thanks for the review. Committed: 1. Add a test for driver options from m_x86_Features_Group (http://reviews.llvm.org/rL268487) 2. Add missing -mno-cx16 driver option (http://reviews.llvm.org/rL268488) 3. Add -m[no-]x87 and -m[no-]80387 options to control

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

This revision was automatically updated to reflect the committed changes. Closed by commit rL268487: Add a test for driver options from m_x86_Features_Group. (authored by aturetsk). Changed prior to commit: http://reviews.llvm.org/D19658?vs=55579=56125#toc Repository: rL LLVM

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Nice. If you wouldn't mind splitting out into 3 patches (all ok): a) The initial testcase, b) the mno-cx16 patch and associated test c) The x87 part and associated test. You'll also want

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk added a comment. Hi, Thanks for the review. All m_x86_Features_Group options are handled in function handleTargetFeaturesGroup from lib/Driver/Tools.cpp, so there is no additional code needed. There was no test for this, so I added a new one trying to cover all options from

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk updated this revision to Diff 55579. aturetsk added a comment. Add a missing option and a test. http://reviews.llvm.org/D19658 Files: include/clang/Driver/Options.td test/Driver/x86-target-features.c Index: test/Driver/x86-target-features.c

Re: [PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

bruno added a subscriber: bruno. bruno added a reviewer: bruno. bruno added a comment. Hi Andrey, What about the code / tests that check for this flags? http://reviews.llvm.org/D19658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D19658: [X86] Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87

aturetsk created this revision. aturetsk added reviewers: rsmith, echristo. aturetsk added subscribers: cfe-commits, zinovy.nis. Herald added a subscriber: joker.eph. Add -m[no-]x87 and -m[no-]80387 options to control FeatureX87. -m[no-]80387 options is added for compatibility with GCC.