Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Eric Fiselier via cfe-commits]

EricWF added a comment.

In http://reviews.llvm.org/D19698#416315, @rsmith wrote:

> In http://reviews.llvm.org/D19698#416309, @EricWF wrote:
>
> > Most tests pretty much rely on  getting dragged in indirectly, 
> > same thing with  and the bits of  we actually define in 
> > .
>
>
> There are also a few symbols that libc++ defines in the wrong header and then 
> #includes into the right one. Any automated fix is going to mess up on those.


Ah, I stupidly assumed that the automatic fix would handle "std::" symbols 
based off of the spec and not the implementation.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Richard Smith via cfe-commits]

rsmith added a comment.

In http://reviews.llvm.org/D19698#416309, @EricWF wrote:

> Most tests pretty much rely on  getting dragged in indirectly, 
> same thing with  and the bits of  we actually define in 
> .


There are also a few symbols that libc++ defines in the wrong header and then 
#includes into the right one. Any automated fix is going to mess up on those.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Eugene Zelenko via cfe-commits]

Eugene.Zelenko added a comment.

> I was hoping that maybe "Include What You Use" had a fix-it mode. I'll look 
> into this further tonight.


It has fix_includes.py script, but I encountered quite a lot of false 
positives, so I prefer to fix problems manually.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Eric Fiselier via cfe-commits]

EricWF added a comment.

In http://reviews.llvm.org/D19698#416306, @rsmith wrote:

> In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote:
>
> > It'll be good idea to run Include What You Use 
> >  to make sure 
> > that all dependencies are explicit.
>
>
> You can also remove all the `export *`s from the module map and try running 
> the testsuite with modules enabled for a nasty shock about how common this 
> problem is...


Most tests pretty much rely on  getting dragged in indirectly, 
same thing with  and the bits of  we actually define in 
.

I was hoping that maybe "Include What You Use" had a fix-it mode. I'll look 
into this further tonight.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Richard Smith via cfe-commits]

rsmith added a subscriber: rsmith.
rsmith added a comment.

In http://reviews.llvm.org/D19698#416255, @Eugene.Zelenko wrote:

> It'll be good idea to run Include What You Use 
>  to make sure 
> that all dependencies are explicit.


You can also remove all the `export *`s from the module map and try running the 
testsuite with modules enabled for a nasty shock about how common this problem 
is...


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Eric Fiselier via cfe-commits]

EricWF closed this revision.
EricWF added a comment.

r267958.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Eric Fiselier via cfe-commits]

EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.

Woops. My bad.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Eugene Zelenko via cfe-commits]

Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.

It'll be good idea to run Include What You Use 
 to make sure 
that all dependencies are explicit.


http://reviews.llvm.org/D19698



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D19698: [libcxx] [test] Need to include for std::unique_ptr.

[Stephan T. Lavavej via cfe-commits]

STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.

[libcxx] [test] Need to include  for std::unique_ptr.

Fixes MSVC "error C2039: 'unique_ptr': is not a member of 'std'".

http://reviews.llvm.org/D19698

Files:
  test/std/utilities/meta/meta.rel/is_callable.pass.cpp

Index: test/std/utilities/meta/meta.rel/is_callable.pass.cpp
===
--- test/std/utilities/meta/meta.rel/is_callable.pass.cpp
+++ test/std/utilities/meta/meta.rel/is_callable.pass.cpp
@@ -18,6 +18,7 @@
 
 #include 
 #include 
+#include 
 
 #include "test_macros.h"
 


Index: test/std/utilities/meta/meta.rel/is_callable.pass.cpp
===
--- test/std/utilities/meta/meta.rel/is_callable.pass.cpp
+++ test/std/utilities/meta/meta.rel/is_callable.pass.cpp
@@ -18,6 +18,7 @@
 
 #include 
 #include 
+#include 
 
 #include "test_macros.h"
 
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits