EricWF commandeered this revision.
EricWF edited reviewers, added: STL_MSFT; removed: EricWF.
EricWF added a comment.
Stealing this review from STL.
http://reviews.llvm.org/D19758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
STL_MSFT added a comment.
Makes sense. MSVC will never have C++03 or C++11 modes (only 14/17/future) so
anything you do in C++03 mode is fine by me.
http://reviews.llvm.org/D19758
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
EricWF added a comment.
I actually want this form of initialization to break in C++03, From the
original review:
> After putting this question up on cfe-dev I have decided that it would be
> best to allow the use of in C++03. Although static initialization is
> a concern the syntax required
STL_MSFT added a comment.
Since you control the definition of ATOMIC_FLAG_INIT, can you make it something
like __secret_tag_type() in C++03? That would allow you to continue to provide
the atomic_flag(bool) extension in C++03.
http://reviews.llvm.org/D19758
EricWF added a comment.
This is a small problem. We actually provide in C++03 minus
`ATOMIC_FLAG_INIT` since it requires C++11.
I'll come up with a way to fix these tests so they keep working in C++03.
http://reviews.llvm.org/D19758
___
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Replace non-Standard "atomic_flag f(false);" with Standard
"atomic_flag f = ATOMIC_FLAG_INIT;".
The test init03.pass.cpp is explicitly testing this
