arsenm closed this revision.
arsenm added a comment.
r279463
https://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rivanvx added a comment.
Addressed both concerns.
https://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm added inline comments.
Comment at: lib/CodeGen/TargetInfo.cpp:6856
@@ +6855,3 @@
+ }
+ else if (StrTy->getNumElements() == 1) {
+// Coerce single element structs to its element.
No else after return
Comment at:
rivanvx updated this revision to Diff 64417.
rivanvx added a comment.
Specifically handle only kernels.
https://reviews.llvm.org/D20168
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
Index: test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
rivanvx updated this revision to Diff 58920.
rivanvx added a comment.
Updated patch. Single element structs are coerced to its element, and there are
tests for structs of different sizes, structs of arrays, structs containing
structs. Arrays of structs are disallowed by clang in kernels.
arsenm added a comment.
Also some tests for non-kernel functions. We might want to keep this as byval
for calling those
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arsenm added a comment.
Some larger and smaller structs too. I think it would be good if single element
structs are replaced with the element type
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arsenm added a comment.
Can you add some tests that include arrays, struct within structs and arrays of
structs?
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rivanvx updated this revision to Diff 57023.
rivanvx added a comment.
Now with 100% more tests.
http://reviews.llvm.org/D20168
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
Index: test/CodeGenOpenCL/amdgpu-abi-struct-coerce.cl
arsenm added a comment.
Needs tests
http://reviews.llvm.org/D20168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rivanvx created this revision.
rivanvx added reviewers: arsenm, tstellarAMD.
rivanvx added a subscriber: cfe-commits.
Herald added a subscriber: kzhuravl.
Structs are currently handled as pointer + byval, which makes AMDGPU LLVM
backend generate incorrect code when structs are used. This patch
12 matches
Mail list logo
