Anastasia closed this revision.
Anastasia added a comment.
r274540 and r274509
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bader added a comment.
LGTM!
Thanks a lot for working on this.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia marked an inline comment as done.
Anastasia added a comment.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia updated this revision to Diff 62485.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Undo removal of anonymous namespace and move the position of function
definition instead.
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
bader added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:6773-6774
@@ -6772,4 +7016,2 @@
-namespace {
-
/// Structure recording the 'active' range of an integer-valued
The con of this change - it will export all the symbols from this unnamed
Anastasia marked 12 inline comments as done.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
bader wrote:
> [Style]
Anastasia updated this revision to Diff 62376.
Anastasia added a comment.
- Fixed style issues
- Added warning diagnostics for conversions of integer types
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
bader accepted this revision.
bader added a comment.
LGTM.
A few style nitpicks.
Comment at: lib/CodeGen/CGBuiltin.cpp:2180-2181
@@ +2179,4 @@
+}
+// Could have events and/or vaargs.
+if (NumArgs >= 5) {
+ if (E->getArg(3)->getType()->isBlockPointerType()) {
Anastasia marked 4 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:145
@@ +144,3 @@
+}
+
+/// OpenCL v2.0, s6.13.17.1 - Check that sizes are provided for all
I think the problem is that in C99 there are implicit casts among integer
types,
Anastasia updated this revision to Diff 61816.
Anastasia added a comment.
Addressed Alexey's comments:
- Removed redundant checks;
- Improved diagnostics of parameters to blocks and sizes of block parameters;
- Handled casting of integer types for specifying sizes of block parameters;
bader added a comment.
Hi Anastasia,
Sorry for the delay.
I have just a few comments.
Thanks,
Alexey
Comment at: lib/Sema/SemaChecking.cpp:95
@@ +94,3 @@
+ IllegalParams = true;
+ break;
+}
It looks like this function will report only first
Anastasia added a comment.
Alexey, do you have any additional comments?
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Anastasia added a comment.
Ping! :)
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia marked 2 inline comments as done.
Anastasia added a comment.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia updated this revision to Diff 60339.
Anastasia added a comment.
Fixed issue with block typedef.
http://reviews.llvm.org/D20249
Files:
include/clang/AST/Type.h
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
Anastasia updated this revision to Diff 60330.
Anastasia marked 2 inline comments as done.
Anastasia added a comment.
- Allow passing array of events as a valid event list object (following C
implicit cast rules of arrays to pointers) in enqueue_kernel function.
- Added failing test case!
-
bader added a comment.
Sorry for the delay.
Is this code valid:
clk_event_t e1, e2, e3;
clk_event_t events[] = {e1, e2};
enqueue_kernel(get_default_queue(), 0, get_ndrange(), 2, events, , ...);
With this patch clang rejects it with an error:
'illegal call to enqueue_kernel, expected
Anastasia marked 2 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:81
@@ +80,3 @@
+static bool checkBlockArgs(Sema , Expr *BlockArg) {
+ const BlockPointerType *BPT = cast(BlockArg->getType());
+ ArrayRef Params =
bader wrote:
> There should be
Anastasia updated this revision to Diff 58403.
Anastasia marked an inline comment as done.
Anastasia added a comment.
Updates from Alexey's comments:
- Use canonical type while casting to block.
- Added failing case to Sema tests.
- Modified CodeGen tests due to captures ordering issue.
bader added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:81
@@ +80,3 @@
+static bool checkBlockArgs(Sema , Expr *BlockArg) {
+ const BlockPointerType *BPT = cast(BlockArg->getType());
+ ArrayRef Params =
There should be some check before cast.
Here is
Anastasia marked 6 inline comments as done.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ -7819,3 +7819,3 @@
"kernel must have void return type">;
def err_sampler_argument_required : Error<
"sampler_t variable required - got %0">;
It's not
Anastasia updated this revision to Diff 58219.
Anastasia added a comment.
- Improved with suggestions from Sam: reformatting, renaming!
- Removed unused err_opencl_function_not_supported diagnostic.
- Rebased and changed to_addr builtins to allow the same identifier to be used
in earlier than
yaxunl added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7820
@@ +7819,3 @@
+def err_opencl_function_not_supported : Error<
+ "this function is not supported in this version of CL">;
+def err_opencl_enqueue_kernel_incorrect_args : Error<
pekka.jaaskelainen added a comment.
LGTM, FWIW.
http://reviews.llvm.org/D20249
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia added inline comments.
Comment at: include/clang/Basic/Builtins.h:39
@@ -38,3 +38,3 @@
MS_LANG = 0x10, // builtin requires MS mode.
- OCLC_LANG = 0x20, // builtin for OpenCL C only.
+ OCLC20_LANG = 0x20, // builtin for OpenCL C only.
ALL_LANGUAGES = C_LANG
Anastasia created this revision.
Anastasia added reviewers: bader, yaxunl.
Anastasia added subscribers: pekka.jaaskelainen, pxli168, cfe-commits.
An implementation of device side enqueue (DSE) - enqueue_kernel and related
BIFs from OpenCL v2.0 s6.13.17.
This change includes:
1. adding
27 matches
Mail list logo
