Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

2016-05-16 Thread Hans Wennborg via cfe-commits
hans added a comment. I'd leave out the blank lines between DEF_TRAVERSE_STMTs, but the rest looks good. Comment at: include/clang/AST/RecursiveASTVisitor.h:2014 @@ -2002,2 +2013,3 @@ DEF_TRAVERSE_STMT(ObjCAutoreleasePoolStmt, {}) + DEF_TRAVERSE_STMT(CXXForRangeStmt, {

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

2016-05-13 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko updated this revision to Diff 57250. Eugene.Zelenko added a comment. Include mode context. Repository: rL LLVM http://reviews.llvm.org/D20254 Files: include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/IdentifierTable.h lib/Basic/FileManager.cpp Index:

Re: [PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

2016-05-13 Thread Piotr Padlewski via cfe-commits
Prazek added a subscriber: Prazek. Prazek added a comment. Can you post this review with more context? (diff -U9) Repository: rL LLVM http://reviews.llvm.org/D20254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20254: [Clang] Fix some Clang-tidy modernize-use-bool-literals warnings; other minor fixes.

2016-05-13 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: hans, aaron.ballman. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Fix some Include What You Use warnings. I checked this patch on my own build on RHEL 6.