This revision was automatically updated to reflect the committed changes.
Closed by commit rL272986: AMDGPU: Fix supported CL features (authored by
jvesely).
Changed prior to commit:
http://reviews.llvm.org/D20388?vs=60259&id=61060#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20388
Fil
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
jvesely added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely marked an inline comment as done.
jvesely added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely updated this revision to Diff 60259.
jvesely added a comment.
tests all extensions against expected outcome (add negative tests)
enable cl_khr_icd (works ok with mesa)
Repository:
rL LLVM
http://reviews.llvm.org/D20388
Files:
lib/Basic/Targets.cpp
test/Misc/amdgcn.languageOptsOpe
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:1
@@ +1,2 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple amdgcn-unknown-unknown
Negative testing?
Repository:
rL LLVM
http:/
jvesely added inline comments.
Comment at: lib/Basic/Targets.cpp:2024-2025
@@ -2023,2 +2023,4 @@
Builder.defineMacro("__HAS_LDEXPF__");
+if (hasFP64)
+ Builder.defineMacro("__HAS_FP64__");
}
arsenm wrote:
> I don't think we need this. I want dev
arsenm added inline comments.
Comment at: lib/Basic/Targets.cpp:2024-2025
@@ -2023,2 +2023,4 @@
Builder.defineMacro("__HAS_LDEXPF__");
+if (hasFP64)
+ Builder.defineMacro("__HAS_FP64__");
}
I don't think we need this. I want device macros for ot
jvesely marked 2 inline comments as done.
jvesely added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jvesely updated the summary for this revision.
jvesely updated this revision to Diff 59080.
jvesely added a comment.
add has_fp64 macro
Repository:
rL LLVM
http://reviews.llvm.org/D20388
Files:
lib/Basic/Targets.cpp
test/Misc/amdgcn.languageOptsOpenCL.cl
test/Misc/r600.languageOptsOpen
jvesely added inline comments.
Comment at: test/Misc/r600.languageOptsOpenCL.cl:4
@@ +3,3 @@
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown
-target-cpu cypress
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown
-target-cpu
arsenm added inline comments.
Comment at: test/Misc/r600.languageOptsOpenCL.cl:4
@@ +3,3 @@
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown
-target-cpu cypress
+// RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple r600-unknown-unknown
-target-cpu t
jvesely updated the summary for this revision.
jvesely added a subscriber: cfe-commits.
jvesely updated this revision to Diff 58850.
jvesely marked an inline comment as done.
jvesely added a comment.
report only exported extensions.
int64 atomics, fp16, and 3d image writes are actually not curren
jvesely marked an inline comment as done.
jvesely added a comment.
Repository:
rL LLVM
http://reviews.llvm.org/D20388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
14 matches
Mail list logo
