This revision was automatically updated to reflect the committed changes.
Closed by commit rL270834: [MSVC] Support for __unaligned qualifier in
functions (authored by asbokhan).
Changed prior to commit:
http://reviews.llvm.org/D20437?vs=57907=58585#toc
Repository:
rL LLVM
andreybokhanko marked 3 inline comments as done.
Comment at: lib/Sema/SemaExprCXX.cpp:937
@@ -936,2 +936,3 @@
+ CXXThisTypeQuals &= Qualifiers::FastMask;
S.CXXThisTypeOverride
majnemer wrote:
> Can you add a comment for this line.
Done.
Thank you for
majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaExprCXX.cpp:937
@@ -936,2 +936,3 @@
+ CXXThisTypeQuals &= Qualifiers::FastMask;
S.CXXThisTypeOverride
Can you add
andreybokhanko updated this revision to Diff 57907.
andreybokhanko added a comment.
Added a test for __unaligned arrays.
http://reviews.llvm.org/D20437
Files:
include/clang/AST/Type.h
include/clang/Sema/DeclSpec.h
lib/AST/DeclCXX.cpp
lib/AST/MicrosoftMangle.cpp
lib/Sema/DeclSpec.cpp
majnemer added inline comments.
Comment at: include/clang/Sema/DeclSpec.h:1152-1169
@@ -1153,19 +1151,20 @@
struct ArrayTypeInfo : TypeInfoCommon {
-/// The type qualifiers for the array: const/volatile/restrict/_Atomic.
-unsigned TypeQuals : 4;
+/// The type
andreybokhanko created this revision.
andreybokhanko added reviewers: rnk, majnemer.
andreybokhanko added a subscriber: cfe-commits.
This adds support of MS-specific "__unaligned" qualifier for function types and
fixes errors described by David Majnemer in this thread:
