timshen added a comment.
Committed as r273312.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen added a comment.
http://reviews.llvm.org/D21243 is committed. Let's do this again.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
timshen reopened this revision.
timshen added a comment.
This revision is now accepted and ready to land.
Clang-tidy is broken by this change. Dependency is added to track the fix.
Repository:
rL LLVM
http://reviews.llvm.org/D20498
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL272296: [Temporary] Add an ExprWithCleanups for each C++
MaterializeTemporaryExpr. (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D20498?vs=58694=60227#toc
Repository:
rL
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
timshen marked an inline comment as done.
timshen added a comment.
Ping? :)
http://reviews.llvm.org/D20498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen updated this revision to Diff 58694.
timshen marked 2 inline comments as done.
timshen added a comment.
Removed C++ constrain and added back the missing comment line.
http://reviews.llvm.org/D20498
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
rsmith added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6197
@@ +6196,3 @@
+ // but there may be a chance to merge them.
+ if (getLangOpts().CPlusPlus)
+Cleanup.setExprNeedsCleanups(false);
Why is this C++-only? We presumably would want to clean up
timshen marked 7 inline comments as done.
Comment at: lib/Sema/SemaInit.cpp:6190-6191
@@ +6189,4 @@
+ MaterializeTemporaryExpr(T, Temporary, BoundToLvalueReference);
+
+ // Order an ExprWithCleanups for lifetime marks.
+ //
> Please also sink the calls to
timshen updated this revision to Diff 58676.
timshen added a comment.
Update to reflect the comments.
http://reviews.llvm.org/D20498
Files:
include/clang/AST/ExprCXX.h
include/clang/AST/Stmt.h
include/clang/Sema/CleanupInfo.h
include/clang/Sema/ScopeInfo.h
include/clang/Sema/Sema.h
rsmith added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:5636-5639
@@ -5634,4 +5635,6 @@
- Expr *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups);
+ auto *E = ExprWithCleanups::Create(Context, SubExpr, Cleanups);
+ if (Cleanup.cleanupsHaveSideEffects())
+
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
These ExprWithCleanups are added for holding a RunCleanupsScope not
for destructor calls; rather, they are for lifetime marks. This requires
12 matches
Mail list logo