Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

This revision was automatically updated to reflect the committed changes. Closed by commit rL276455: Add .rgba syntax extension to ext_vector_type types (authored by pirama). Changed prior to commit: https://reviews.llvm.org/D20602?vs=62305=65119#toc Repository: rL LLVM

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 62305. pirama added a comment. Added GroupInfo to warning. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907 @@ -7904,1 +7906,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL version 2.2 feature">; } // end of sema category

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60723. pirama added a comment. - Undo bad merge from different patch http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60718. pirama added a comment. Herald added subscribers: danalbert, tberghammer. - Add TargetInfo for 32-bit and 64-bit RenderScript http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7907 @@ -7904,1 +7906,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL version 2.2 feature">; } // end of sema category

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 60425. pirama added a comment. Convert error to warning, update tests, and rename variable name. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900 @@ -7897,1 +7899,3 @@ +def err_opencl_ext_vector_type_rgba_selector: Error< + "vector component name '%0' cannot be used earlier than OpenCL version 2.2">; } // end of sema category

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. Friendly ping... http://reviews.llvm.org/D20602 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58813. pirama added a comment. Switched to emitting errors when rgba is used in OpenCL < 2.2. Also, fixed the diagnostic's name mismatch at its point of issue. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900 @@ -7897,1 +7899,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL 2.2 extension">; } // end of sema category

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

Anastasia added a subscriber: Anastasia. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7900 @@ -7897,1 +7899,3 @@ +def ext_opencl_ext_vector_type_rgba_selector: ExtWarn< + "vector component name '%0' is an OpenCL 2.2 extension">; } // end of sema category

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58537. pirama added a comment. Renamed diagnostic to use ext_ prefix. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp test/CodeGen/ext-vector.c

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58535. pirama added a comment. Switched to ExtWarn, updated warning's message and made the version check strict w.r.t. 2.2. http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added a comment. Looks good other than the recent information about the version of OpenCL that actually specifies this. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7899 @@ +7898,3 @@ +// OpenCL v2.2 s2.1.2.3 - Vector Component Access +def

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. > > > I'm not suggesting it be treated as invalid. This extension is part of at > > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > > > Clang's implementation of the OpenCL vector type. Therefore if the user > > > asks us to support OpenCL

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama updated this revision to Diff 58525. pirama added a comment. Added warnings when rgba is used with OpenCL http://reviews.llvm.org/D20602 Files: include/clang/AST/Type.h include/clang/Basic/DiagnosticSemaKinds.td lib/AST/Expr.cpp lib/Sema/SemaExprMember.cpp

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

On Wed, May 25, 2016 at 2:20 PM, Aleksey Bader wrote: > On Wed, May 25, 2016 at 11:53 PM, Richard Smith > wrote: > >> On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> bader added a

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

On Wed, May 25, 2016 at 11:53 PM, Richard Smith wrote: > On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> bader added a subscriber: bader. >> bader added a comment. >> >> In http://reviews.llvm.org/D20602#438667,

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

On Wed, May 25, 2016 at 2:20 AM, Alexey Bader via cfe-commits < cfe-commits@lists.llvm.org> wrote: > bader added a subscriber: bader. > bader added a comment. > > In http://reviews.llvm.org/D20602#438667, @rsmith wrote: > > > I'm not suggesting it be treated as invalid. This extension is part of

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama added a comment. To summarize, there are two scenarios where a warning is warranted when the source language is OpenCL: > > I'm not suggesting it be treated as invalid. This extension is part of at > > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > > Clang's

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

bader added a subscriber: bader. bader added a comment. In http://reviews.llvm.org/D20602#438667, @rsmith wrote: > I'm not suggesting it be treated as invalid. This extension is part of at > least OpenCL 2.1, but it's not part of OpenCL 1.0. `ext_vector_type` is > Clang's implementation of the

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added a comment. In http://reviews.llvm.org/D20602#438643, @srhines wrote: > In http://reviews.llvm.org/D20602#438528, @rsmith wrote: > > > Looks like this extension was added at some point between 1.1 and 2.1. It > > would make sense to produce an `ExtWarn` for it if the OpenCL standard

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

srhines added a comment. In http://reviews.llvm.org/D20602#438528, @rsmith wrote: > Looks like this extension was added at some point between 1.1 and 2.1. It > would make sense to produce an `ExtWarn` for it if the OpenCL standard > version is less than the one that introduced it (whenever

Re: [PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

rsmith added a comment. Looks like this extension was added at some point between 1.1 and 2.1. It would make sense to produce an `ExtWarn` for it if the OpenCL standard version is less than the one that introduced it (whenever that was) -- that would match what we do for extensions in other

[PATCH] D20602: Add .rgba syntax extension to ext_vector_type types

pirama created this revision. pirama added subscribers: cfe-commits, srhines. This patch enables .rgba accessors to ext_vector_type types and adds tests for syntax validation and code generation. 'a' and 'b' can appear either in the point access mode or the numeric access mode (for indices 10