Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-06-10 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. LGTM! Looks much cleaner now. Please, add me to related reviews later on. Thanks! http://reviews.llvm.org/D20681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-06-08 Thread Yaxun Liu via cfe-commits
yaxunl updated this revision to Diff 60105. yaxunl marked an inline comment as done. yaxunl added a comment. Refactor to eliminate lambda function argument. http://reviews.llvm.org/D20681 Files: include/clang/CodeGen/BackendUtil.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CodeGenAction.cpp

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-06-08 Thread Yaxun Liu via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added a comment. > > We have prelinking passes in amdgpu backend but it requires the llvm change > > to be committed first. We can add a test for this after that. > > > Sure. Could you subscribe me to the relevant backend reviews if possible

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-06-08 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. In http://reviews.llvm.org/D20681#450073, @yaxunl wrote: > In http://reviews.llvm.org/D20681#448443, @Anastasia wrote: > > > Do you think we could add any test for this change? > > > We have prelinking passes in amdgpu backend but it requires the llvm change > to be

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-06-06 Thread Yaxun Liu via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added a comment. In http://reviews.llvm.org/D20681#448443, @Anastasia wrote: > Do you think we could add any test for this change? We have prelinking passes in amdgpu backend but it requires the llvm change to be committed first. We can add a

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-06-03 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. Do you think we could add any test for this change? Comment at: lib/CodeGen/BackendUtil.cpp:657 @@ -627,2 +656,3 @@ + bool EmitAssemblyHelper::AddEmitPasses(BackendAction Action, Remove the empty line please

RE: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-05-26 Thread Liu, Yaxun (Sam) via cfe-commits
To: reviews+d20681+public+7364792746786...@reviews.llvm.org; rich...@metafoo.co.uk; anastasia.stul...@arm.com Cc: Stellard, Thomas <tom.stell...@amd.com>; cfe-commits@lists.llvm.org; Sumner, Brian <brian.sum...@amd.com> Subject: RE: [PATCH] D20681: Add target-specific pre-linking pas

RE: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-05-26 Thread Liu, Yaxun (Sam) via cfe-commits
.org Subject: Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang tstellarAMD added a comment. Can you give some examples of what pre-link passes may be required? http://reviews.llvm.org/D20681 ___ cfe-commits mailing list

Re: [PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-05-26 Thread Tom Stellard via cfe-commits
tstellarAMD added a comment. Can you give some examples of what pre-link passes may be required? http://reviews.llvm.org/D20681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20681: Add target-specific pre-linking passes to Clang

2016-05-26 Thread Yaxun Liu via cfe-commits
yaxunl created this revision. yaxunl added reviewers: rsmith, Anastasia. yaxunl added subscribers: cfe-commits, tstellarAMD. Sometimes a backend needs to apply certain target-specific passes before linking. This patch attempts to add that. It depends on a new virtual member function