Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

2016-06-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271454: [docs] Document the source-based code coverage feature (authored by vedantk). Changed prior to commit: http://reviews.llvm.org/D20715?vs=59078=59322#toc Repository: rL LLVM

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

2016-06-01 Thread Vedant Kumar via cfe-commits
> On Jun 1, 2016, at 11:30 AM, Justin Bogner wrote: > > Vedant Kumar writes: >> vsk created this revision. >> vsk added a reviewer: bogner. >> vsk added subscribers: kcc, cfe-commits, silvas. >> >> It would be helpful to have a user-friendly guide for

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

2016-06-01 Thread Justin Bogner via cfe-commits
Vedant Kumar writes: > vsk created this revision. > vsk added a reviewer: bogner. > vsk added subscribers: kcc, cfe-commits, silvas. > > It would be helpful to have a user-friendly guide for code > coverage. There is some overlap with [1], but this document visits > issues which

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

2016-05-31 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 59078. vsk marked an inline comment as done. vsk added a comment. - Actually link in the new document into Index.rst. http://reviews.llvm.org/D20715 Files: docs/SourceBasedCodeCoverage.rst docs/index.rst Index: docs/index.rst

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

2016-05-27 Thread Vedant Kumar via cfe-commits
vsk updated this revision to Diff 58810. vsk marked 4 inline comments as done. vsk added a comment. Thanks for the feedback! - Addressed Sean's review comments. - Fixed the line count displayed in the summary view of `foo`. http://reviews.llvm.org/D20715 Files:

Re: [PATCH] D20715: [docs] Document the source-based code coverage feature

2016-05-27 Thread Sean Silva via cfe-commits
silvas added subscribers: MaggieYi, phillip.power. silvas added a comment. This is looking really good. So based on reading this, a rough sketch of how we can expand this to PGO would be something like: - there is a separate PGO page that has similar structure, but is more tuned for the PGO

[PATCH] D20715: [docs] Document the source-based code coverage feature

2016-05-26 Thread Vedant Kumar via cfe-commits
vsk created this revision. vsk added a reviewer: bogner. vsk added subscribers: kcc, cfe-commits, silvas. It would be helpful to have a user-friendly guide for code coverage. There is some overlap with [1], but this document visits issues which may affect users in more depth. Prompted by: