Re: [PATCH] D20814: [include-fixer] Rank symbols based on the number of occurrences we found while merging.

2016-05-31 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271283: [include-fixer] Rank symbols based on the number of occurrences we found… (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D20814?vs=59062=59065#toc Repository: rL LLVM

Re: [PATCH] D20814: [include-fixer] Rank symbols based on the number of occurrences we found while merging.

2016-05-31 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. This revision is now accepted and ready to land. Comment at: include-fixer/SymbolIndexManager.cpp:25 @@ +24,3 @@ + // First collect occurrences per header file. + std::map HeaderPopularity; + for (const SymbolInfo :

[PATCH] D20814: [include-fixer] Rank symbols based on the number of occurrences we found while merging.

2016-05-31 Thread Benjamin Kramer via cfe-commits
bkramer created this revision. bkramer added reviewers: ioeric, djasper. bkramer added a subscriber: cfe-commits. This sorts based on the popularity of the header, not the symbol. If there are mutliple matching symbols in one header we take the maximum popularity for that header and deduplicate.