Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

2016-06-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271409: ObjC lifetime: pull sugar off when the qualifiers conflict. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D20843?vs=59149=59249#toc Repository: rL LLVM

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

2016-06-01 Thread Manman Ren via cfe-commits
manmanren added a comment. In http://reviews.llvm.org/D20843#445756, @rjmccall wrote: > Oh sure, because we don't strip the original type if there isn't a conflict. > LGTM. Exactly, thanks for reviewing! Manman http://reviews.llvm.org/D20843

Re: [PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

2016-06-01 Thread John McCall via cfe-commits
rjmccall added a comment. Oh sure, because we don't strip the original type if there isn't a conflict. LGTM. http://reviews.llvm.org/D20843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D20843: ObjC lifetime: pull sugar off when the qualifiers conflict.

2016-05-31 Thread Manman Ren via cfe-commits
manmanren created this revision. manmanren added a reviewer: rjmccall. manmanren added a subscriber: cfe-commits. It's possible to have multiple local ObjCLifetime qualifiers. When there is a conflict, we can't stop after we reach a type that is directly qualified. We need to keep pulling sugar