Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

2016-06-20 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273193: [Sema] Only define function as move assignment when needed (authored by epilk). Changed prior to commit: http://reviews.llvm.org/D20923?vs=59409=61296#toc Repository: rL LLVM

Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

2016-06-20 Thread Manman Ren via cfe-commits
manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM. Manman http://reviews.llvm.org/D20923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

2016-06-16 Thread Erik Pilkington via cfe-commits
erik.pilkington added a comment. Ping! http://reviews.llvm.org/D20923 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D20923: [Sema] Fix a crash on invalid where invalid defaulted function is called

2016-06-02 Thread Erik Pilkington via cfe-commits
erik.pilkington created this revision. erik.pilkington added a reviewer: rsmith. erik.pilkington added a subscriber: cfe-commits. Previously, clang would crash on the test case below, because it misinterprets the `operator=(bool)` call as a move assignment operator.