[PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In D21113#2859165 , @Yoav wrote: > Any progress with this? @hans its been stale for a while now and this feature > is crucial No progress, I'm afraid. I'm not working on this, so someone would have to take over the patch to push

[PATCH] D21113: Add support for case-insensitive header lookup

Yoav added a comment. Herald added a subscriber: dang. Any progress with this? @hans its been stale for a while now and this feature is crucial CHANGES SINCE LAST ACTION https://reviews.llvm.org/D21113/new/ https://reviews.llvm.org/D21113 ___

[PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In https://reviews.llvm.org/D21113#627413, @francisco.lopes wrote: > I'm waiting for this to land as well, it's crucial for coding windows code > with libclang assistance on a linux machine. I'm not actively working on this, so it might take a while. In the meantime, I

[PATCH] D21113: Add support for case-insensitive header lookup

pcc added inline comments. Comment at: lib/Basic/VirtualFileSystem.cpp:483 +CaseInsensitiveFileSystem::openFileForRead(const Twine ) { + SmallVector NewPath; + if (std::error_code EC = findCaseInsensitivePath(Path.str(), NewPath)) I wonder whether

[PATCH] D21113: Add support for case-insensitive header lookup

francisco.lopes added a comment. I'm waiting for this to land as well, it's crucial for coding windows code with libclang assistance on a linux machine. https://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21113: Add support for case-insensitive header lookup

sheu added a subscriber: sheu. sheu added a comment. I'd be very interested in seeing this patch happen. What's the current status here? Also, w.r.t. the cache invalidation problem -- would it be feasible / a good idea to move users of the FileSystem API to VirtualFileSystem, in general?

Re: [PATCH] D21113: Add support for case-insensitive header lookup

On Fri, Jun 10, 2016 at 10:35:26AM -0700, Hans Wennborg wrote: > On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits > wrote: > > On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits > > wrote: > >> There has been a patch for this

Re: [PATCH] D21113: Add support for case-insensitive header lookup

On Thu, Jun 9, 2016 at 5:31 PM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Jun 08, 2016 at 01:12:31AM +, Hans Wennborg via cfe-commits wrote: >> There has been a patch for this before (http://reviews.llvm.org/D2972), >> but this one is more general, as it

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60220. hans added a comment. Adding the version that caches directory contents. This has the problem the it doesn't play with modules, the rewriter, and possibly others, because they write to the file system without any way for the vfs to find out. I've tried

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452673, @thakis wrote: > Not sure if we want a flag that adds 50% overhead, no matter how convenient > it might be :-/ I now have a version of the patch that caches directory contents that it lists: real2m31.461s user

Re: [PATCH] D21113: Add support for case-insensitive header lookup

thakis added a comment. Not sure if we want a flag that adds 50% overhead, no matter how convenient it might be :-/ http://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452558, @thakis wrote: > Can you try building a few more files? Say, v8_base? Well, that was depressing: Putting the sdk on a vfat fs: real2m26.077s user68m31.476s sys 1m25.702s Using the flag: real9m5.179s

Re: [PATCH] D21113: Add support for case-insensitive header lookup

thakis added a comment. Can you try building a few more files? Say, v8_base? http://reviews.llvm.org/D21113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans added a comment. In http://reviews.llvm.org/D21113#452431, @thakis wrote: > For performance: Can you check how build times for some large target in > Chromium on Linux targeting Windows compares with this vs having the sdk in a > fat mount? That would give us some data. I measured

Re: [PATCH] D21113: Add support for case-insensitive header lookup

thakis added a comment. For performance: Can you check how build times for some large target in Chromium on Linux targeting Windows compares with this vs having the sdk in a fat mount? That would give us some data. The discussion in the include case warning thread sounds like MS might update

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 60054. hans marked 2 inline comments as done. hans added a comment. Addressing Saleem's comments, and renaming the flag to -fcase-insensitive-paths, since this doesn't apply just to includes, but anything that goes through vfs, including the main source

Re: [PATCH] D21113: Add support for case-insensitive header lookup

compnerd added a comment. This looks good to me. Thanks for picking this up! And thanks for the perf numbers! Comment at: lib/Basic/VirtualFileSystem.cpp:401 @@ +400,3 @@ +IntrusiveRefCntPtr Base) +: Base(Base) {} + Probably can inline this in the

Re: [PATCH] D21113: Add support for case-insensitive header lookup

hans updated this revision to Diff 59982. hans added a comment. Add --show-includes test. http://reviews.llvm.org/D21113 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Driver/Options.td include/clang/Lex/HeaderSearchOptions.h lib/Basic/VirtualFileSystem.cpp

[PATCH] D21113: Add support for case-insensitive header lookup

hans created this revision. hans added reviewers: rsmith, rnk, thakis. hans added subscribers: compnerd, majnemer, benlangmuir, cfe-commits. This is useful when dealing with headers that are normally used on case-insensitive filesystems, such as the Windows SDK, when cross-compiling from a