This revision was automatically updated to reflect the committed changes.
Closed by commit rL272413: Strip Android version when looking up toolchain
paths. (authored by jmgao).
Changed prior to commit:
http://reviews.llvm.org/D21163?vs=60294=60379#toc
Repository:
rL LLVM
jmgao added a comment.
Thanks for the review!
http://reviews.llvm.org/D21163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
t.p.northover accepted this revision.
t.p.northover added a reviewer: t.p.northover.
t.p.northover added a comment.
This revision is now accepted and ready to land.
I think that looks good. Thanks for adding the test!
Tim.
http://reviews.llvm.org/D21163
jmgao updated this revision to Diff 60294.
jmgao added a comment.
Add test.
http://reviews.llvm.org/D21163
Files:
lib/Driver/Driver.cpp
test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld
test/Driver/Inputs/android_triple_version/bin/arm-linux-androideabi-ld.exe
t.p.northover added a subscriber: t.p.northover.
t.p.northover added a comment.
This could do with a test in test/Driver.
http://reviews.llvm.org/D21163
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jmgao created this revision.
jmgao added reviewers: srhines, danalbert.
jmgao added a subscriber: cfe-commits.
Herald added subscribers: srhines, danalbert, tberghammer, aemerson.
Android target triples can include a version number in the abi field
(e.g. 'aarch64-linux-android21'), used for
