Re: [PATCH] D21181: [include-fixer] give users an option to show N more headers in case there are too many candidates.

2016-06-10 Thread Eric Liu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272387: [include-fixer] give users an option to show N more headers in case there areā€¦ (authored by ioeric). Changed prior to commit: http://reviews.llvm.org/D21181?vs=60338=60342#toc Repository: rL

Re: [PATCH] D21181: [include-fixer] give users an option to show N more headers in case there are too many candidates.

2016-06-10 Thread Eric Liu via cfe-commits
ioeric updated this revision to Diff 60338. ioeric added a comment. - remove option (a) in favor of option (m); show a new prompt on invalid option instead of aborting. http://reviews.llvm.org/D21181 Files: include-fixer/tool/clang-include-fixer.py Index:

Re: [PATCH] D21181: [include-fixer] give users an option to show N more headers in case there are too many candidates.

2016-06-10 Thread Benjamin Kramer via cfe-commits
bkramer added a comment. I'm not convinced that this use case is common enough to make the interface more complex. Should we remove (a) in favor of this? http://reviews.llvm.org/D21181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D21181: [include-fixer] give users an option to show N more headers in case there are too many candidates.

2016-06-09 Thread Eric Liu via cfe-commits
ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. give users an option to show N more headers in case there are too many candidates. http://reviews.llvm.org/D21181 Files: include-fixer/tool/clang-include-fixer.py Index: