Re: [PATCH] D21186: clang-rename: mark the DynamicCastExpr test unsupported on ps4

2016-06-10 Thread Sean Silva via cfe-commits
silvas added a comment. In http://reviews.llvm.org/D21186#454497, @silvas wrote: > > It has no RTTI, so the test would always fail in a non-interesting way. > > > It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You > can fix this by explicitly adding -frtti I believe.

Re: [PATCH] D21186: clang-rename: mark the DynamicCastExpr test unsupported on ps4

2016-06-10 Thread Sean Silva via cfe-commits
silvas added a subscriber: silvas. silvas added a comment. > It has no RTTI, so the test would always fail in a non-interesting way. It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You can fix this by explicitly adding -frtti I believe.

[PATCH] D21186: clang-rename: mark the DynamicCastExpr test unsupported on ps4

2016-06-09 Thread Miklos Vajna via cfe-commits
vmiklos created this revision. vmiklos added a reviewer: klimek. vmiklos added a subscriber: cfe-commits. It has no RTTI, so the test would always fail in a non-interesting way. http://reviews.llvm.org/D21186 Files: test/clang-rename/DynamicCastExpr.cpp Index: