Re: [PATCH] D21212: Add documentation for RenderScript changes

2016-06-21 Thread Pirama Arumuga Nainar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL273283: Add documentation for RenderScript changes (authored by pirama). Changed prior to commit: http://reviews.llvm.org/D21212?vs=61390=61391#toc Repository: rL LLVM

Re: [PATCH] D21212: Add documentation for RenderScript changes

2016-06-21 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 61390. pirama added a comment. computation -> computations. http://reviews.llvm.org/D21212 Files: docs/ReleaseNotes.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

Re: [PATCH] D21212: Add documentation for RenderScript changes

2016-06-21 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a tiny wording nit. Comment at: include/clang/Basic/AttrDocs.td:2444 @@ +2443,3 @@ +In RenderScript, ``kernel`` functions are used to express

Re: [PATCH] D21212: Add documentation for RenderScript changes

2016-06-10 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60412. pirama added a comment. Rebase after submission of http://reviews.llvm.org/D21240. http://reviews.llvm.org/D21212 Files: docs/ReleaseNotes.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

Re: [PATCH] D21212: Add documentation for RenderScript changes

2016-06-10 Thread Pirama Arumuga Nainar via cfe-commits
pirama updated this revision to Diff 60394. pirama added a comment. Expand description of RenderScript kernel functions. http://reviews.llvm.org/D21212 Files: docs/ReleaseNotes.rst include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

Re: [PATCH] D21212: Add documentation for RenderScript changes

2016-06-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added inline comments. Comment at: include/clang/Basic/AttrDocs.td:2440 @@ +2439,3 @@ + let Content = [{ +``__attribute__((kernel))`` is used to mark a ``kernel`` function in RenderScript_. See the RenderScript_ documentation for more information. +

[PATCH] D21212: Add documentation for RenderScript changes

2016-06-09 Thread Pirama Arumuga Nainar via cfe-commits
pirama created this revision. pirama added a reviewer: rsmith. pirama added subscribers: srhines, cfe-commits. Herald added subscribers: danalbert, tberghammer. - Document the new 'kernel' attribute - Mention RenderScript support in the Release Notes. http://reviews.llvm.org/D21212 Files: