timshen abandoned this revision.
timshen added a comment.
> I was wondering why we didn't created that Matcher: IgnoreImplicit
Actually you are right. There already exists a IgnoreImplict in clang-tidy and
I just switched to that.
Abandoning this patch.
Thanks!
etienneb added a subscriber: etienneb.
etienneb added a comment.
I was wondering why we didn't created that Matcher: IgnoreImplicit
I believe it's more commonly used than 'ignoringExprWithCleanups'.
It can be implemented by calling 'Stmt.IgnoreImplicit'.
/// Skip past any implicit AST nodes
aaron.ballman added inline comments.
Comment at: include/clang/ASTMatchers/ASTMatchers.h:629
@@ +628,3 @@
+/// \brief Matches expressions that match InnerMatcher after ExprWithCleanups
+/// are stripped off.
+AST_MATCHER_P(Expr, ignoringExprWithCleanups, internal::Matcher,
timshen updated this revision to Diff 60704.
timshen added a comment.
Done.
http://reviews.llvm.org/D21241
Files:
docs/LibASTMatchersReference.html
include/clang/ASTMatchers/ASTMatchers.h
lib/ASTMatchers/Dynamic/Registry.cpp
unittests/ASTMatchers/ASTMatchersTraversalTest.cpp
Index:
aaron.ballman added a subscriber: aaron.ballman.
aaron.ballman added a reviewer: aaron.ballman.
aaron.ballman added a comment.
Also, please add documentation to the matcher definition and regenerate the
documentation.
http://reviews.llvm.org/D21241
klimek added a comment.
Please add a test.
http://reviews.llvm.org/D21241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This is part of the fix of clang-tidy patterns to adapt to newly added
ExprWithCleanups node.
http://reviews.llvm.org/D21241
Files:
