This revision was automatically updated to reflect the committed changes.
Closed by commit rL273310: Fix clang-tidy patterns to adapt to newly added
ExprWithCleanups nodes. (authored by timshen).
Changed prior to commit:
http://reviews.llvm.org/D21243?vs=60992=61434#toc
Repository:
rL LLVM
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Yes, you're probably not the right person to fix our test coverage. Thanks for
fixing the stuff that broke and I hope we'll figure out what else needs to be
fixed in a finite time after the
timshen updated this revision to Diff 60992.
timshen added a comment.
Updated the patch to use ignorngImplicit/Expr::IgnoreImplicit matcher.
I think there is a systematic way to do this change:
Look at every ignoringImpCasts, ignoringParenCasts, ignoringParenImpCasts,
ignoringParens, and
timshen added a comment.
In http://reviews.llvm.org/D21243#455999, @alexfh wrote:
> Does this just fix the tests broken with http://reviews.llvm.org/D20498 or
> have you looked at other checks that might be broken by
> http://reviews.llvm.org/D20498, but don't have relevant tests?
This just
alexfh added a comment.
In http://reviews.llvm.org/D21243#455999, @alexfh wrote:
> Does this just fix the tests broken with http://reviews.llvm.org/D20498 or
> have you looked at other checks that might be broken by
> http://reviews.llvm.org/D20498, but don't have relevant tests? In the latter
alexfh added a comment.
Does this just fix the tests broken with http://reviews.llvm.org/D20498 or have
you looked at other checks that might be broken by
http://reviews.llvm.org/D20498, but don't have relevant tests? In the latter
case we'd certainly need your help figuring out where further
timshen created this revision.
timshen added a reviewer: rsmith.
timshen added a subscriber: cfe-commits.
This is a fix for the new ExprWithCleanups introduced by clang's temporary
variable lifetime marks change.
http://reviews.llvm.org/D21243
Files:
clang-tidy/llvm/TwineLocalCheck.cpp
