Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 11:27 AM, Zachary Turner wrote: > I agree that it can be annoying to say "hey guys, i would normally do post > commit review on this, but i wanted to give the courtesy of a heads up", > and then potentially waiting an indeterminate amount of time. > >

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 8:55 AM, Michael Spertus wrote: > Hi David, > While I understand the initial reasoning. I have found that this is like a > hundred times better for working on Clang in practice and can't imagine > working without it. The point is that many Clang data

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

Gotcha. Going forward, if I feel anything requires a heads up, I'll do the full pre-commit review. Thanks for the feedback, Mike On Mon, Jun 13, 2016 at 11:30 AM, Aaron Ballman wrote: > On Mon, Jun 13, 2016 at 12:27 PM, Zachary Turner > wrote: > >

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 12:27 PM, Zachary Turner wrote: > I agree that it can be annoying to say "hey guys, i would normally do post > commit review on this, but i wanted to give the courtesy of a heads up", and > then potentially waiting an indeterminate amount of time. > > I

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

I agree that it can be annoying to say "hey guys, i would normally do post commit review on this, but i wanted to give the courtesy of a heads up", and then potentially waiting an indeterminate amount of time. I think that actually discourages these kind of changes going up at all, because people

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

On Mon, Jun 13, 2016 at 11:55 AM, Michael Spertus wrote: > Hi David, > While I understand the initial reasoning. I have found that this is like a > hundred times better for working on Clang in practice and can't imagine > working without it. The point is that many Clang data

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

Hi David, While I understand the initial reasoning. I have found that this is like a hundred times better for working on Clang in practice and can't imagine working without it. The point is that many Clang data structures contain SmallVectors and having to do zero expansion clicks instead of

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

As for the original change proposed: My guiding principle would be "do whatever std::vector does". (& that's what I did when implementing GDB pretty printers for SmallVector/SmallString/ArrayRef, etc... ) An aside: We generally don't do time limited reviews like this. Either something needs

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

mspertus closed this revision. mspertus added a comment. revision 272525 http://reviews.llvm.org/D21256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

mspertus accepted this revision. mspertus added a reviewer: mspertus. mspertus added a comment. This revision is now accepted and ready to land. No adverse (or otherwise) comments received, so committing as revision 272525 http://reviews.llvm.org/D21256

[PATCH] D21256: Improved Visual Studio 2015 visualization of SmallVectorImpl

mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner, aemerson. mspertus added a subscriber: cfe-commits. When visualizing small vectors in VS2015, show the first few elements in the DisplayString instead of the size. For example, a `SmallVector` of `DeclAccessPair`