This revision was automatically updated to reflect the committed changes.
Closed by commit rL273401: [Clang][bmi][intrinsics] Adding _mm_tzcnt_64
_mm_tzcnt_32 intrinsics to clang. (authored by mzuckerm).
Changed prior to commit:
http://reviews.llvm.org/D21373?vs=61351=61536#toc
Repository:
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Headers/bmiintrin.h:284
@@ -283,2 +283,3 @@
///bits in the operand.
+
static __inline__ unsigned int __RELAXED_FN_ATTRS
Why the
m_zuckerman added inline comments.
Comment at: lib/Headers/bmiintrin.h:296
@@ +295,3 @@
+/// This intrinsic corresponds to the \c TZCNT instruction.
+///
+/// \param __X
We can't use #define Here. The __mm_tzcnt_32(a) intrinsics is deferent from
__tzcnt_u32 in
m_zuckerman updated this revision to Diff 61351.
http://reviews.llvm.org/D21373
Files:
lib/Headers/bmiintrin.h
test/CodeGen/bmi-builtins.c
Index: test/CodeGen/bmi-builtins.c
===
--- test/CodeGen/bmi-builtins.c
+++
RKSimon added a subscriber: RKSimon.
RKSimon added a reviewer: RKSimon.
Comment at: lib/Headers/bmiintrin.h:296
@@ -290,1 +295,3 @@
+}
+
#ifdef __x86_64__
Why not just #define to __tzcnt_u32 like the (many) other duplicate tzcnt
intrinsics we have:
```
#define
m_zuckerman created this revision.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: cfe-commits.
http://reviews.llvm.org/D21373
Files:
lib/Headers/bmiintrin.h
test/CodeGen/bmi-builtins.c
Index: test/CodeGen/bmi-builtins.c
