Re: [PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273349. http://reviews.llvm.org/D21582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

2016-06-21 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I think your compiler is silly, but I'm happy with the change anyway. I like that syntax gosh darn it! http://reviews.llvm.org/D21582 ___ cfe-co

[PATCH] D21582: [libcxx] [test] Avoid mixing assignment and returning.

2016-06-21 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid mixing assignment and returning. "return locked = true;" looks really suspicious, even though it happens to be correct here. Spend an extra statement to make the code cl