Re: [PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

2016-06-26 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r273818. http://reviews.llvm.org/D21712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

2016-06-26 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. It seems like this has the possibility to lose some useful diagnostics if a narrowing conversion actually occurs. However I'm OK with the change. http://reviews.llvm.org/D21712 ___

[PATCH] D21712: [libcxx] [test] Avoid narrowing conversions in quoted.pass.cpp.

2016-06-24 Thread Stephan T. Lavavej via cfe-commits
STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Avoid narrowing conversions in quoted.pass.cpp. According to the Standard, when char has a signed range and wchar_t has an unsigned range, brace-init has to reject the potenti