bruening added inline comments.
Comment at: docs/CSI.rst:30
@@ +29,3 @@
+To create a CSI tool, add ``#include `` at the top of the tool source
+and implement function bodies for the hooks relevant to the tool.
+
Are there any constraints on what libraries the tool
mehdi_amini added inline comments.
Comment at: docs/CSI.rst:78
@@ +77,3 @@
+Notice that in the final stage of linking, the tool user also needs to link in
+the static library of the CSI runtime to produce the final TIX. The runtime
+archive is distributed under the ``build/lib/cl
bruening added inline comments.
Comment at: docs/CSI.rst:78
@@ +77,3 @@
+Notice that in the final stage of linking, the tool user also needs to link in
+the static library of the CSI runtime to produce the final TIX. The runtime
+archive is distributed under the ``build/lib/clang
mehdi_amini added inline comments.
Comment at: docs/CSI.rst:46
@@ +45,3 @@
+allows the LTO to later elide hooks irrelevant to the tool entirely from the
+program-under-test.
+
The long thread on llvm-dev went to conclude that LTO should not be needed.
===
bruening added inline comments.
Comment at: docs/CSI.rst:75
@@ +74,3 @@
+ % clang++ -c -O3 -g -fcsi -emit-llvm bar.cpp -o bar.o
+ % clang++ foo.o bar.o my-tool.o libclang_rt.csi-x86_64.a -fuse-ld=gold -flto
-lrt -ldl -o foo
+
See below: the sanitizers pass the
tdenniston created this revision.
tdenniston added reviewers: kcc, zhaoqin, bruening, mehdi_amini.
tdenniston added subscribers: cfe-commits, eugenis, pcc, vitalybuka, aizatsky,
neboat.
tdenniston set the repository for this revision to rL LLVM.
tdenniston added a project: Comprehensive Static Ins
